Repository navigation
chore: prune monorepo residue from config and docs - #2234
Merged
Merged
Conversation
Items from #2097: - 1: drop .golangci.yml exclusions for nonexistent internal/testutil, internal/api, internal/config, pkg/ladder paths - 3: drop .gitignore frontend/* entries - 5: drop the check-yaml exclude entirely - 7: drop NOTICE entries for aws-lambda-go, pgx, pgxmock, golang-migrate and testcontainers (absent from go.mod and go.sum) - 8: point docs/cli server wording and the dead README anchor at cloud-commitments-platform - cloud-setup.md: replace ci-cd-permissions/workflow paragraph and terraform/environments reference with pointers to the platform repo - 12: fix CONTRIBUTING.md claim that --help prints a version Already fixed: items 4 and 6 and the frontend/src/index.html and gosec comment parts of item 5. Refs #2097 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cristim
added
priority/p3
Contributor
|
Warning Review limit reached
This review includes 7 billable files and costs up to $1.75.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 55 minutes for your next included review. View limit details
Comment |
Member
Author
Independent review verdict: CLEAN at ae20221Reviewer: fresh Claude agent, not the author. Coordinator: claude-cc-reviewer.
Merge waits on CI being green at this SHA. (claude-cc-reviewer) |
Member
Author
|
CR waived: quota, adversarial review + local verification + green CI. Merged at ae20221. (claude-cc-reviewer) |
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2097. This PR covers part of the issue. Three items are left open on purpose:
cmd/configure_azure.goandcmd/configure_gcp.go. Both files are touched by open PRs (fix(configure-azure): stop printing the new service principal's client secret (A10-028) #2212 and fix(cli): delete the minted GCP key when the credentials upload panics #2233).ci.yml. That changes what blocks CI, so it needs an owner decision.CLAUDE.md, which docs(claude): coordinate parallel work through issue assignment #2202 is editing.Summary
This PR removes config and doc entries that only made sense in the monorepo. Before each removal I checked with
git ls-filesandlsthat its target does not exist in this repo..golangci.yml: removed the exclusions forinternal/testutil/andinternal/api/(revive), and the misspellcancelled|initialisedrule. All of them were scoped tointernal/orpkg/paths..gitignore: removed thefrontend/*and Playwright entries..pre-commit-config.yaml: dropped the check-yamlexclude. Its docker-compose, cloudformation and iac targets don't exist, and check-yaml passes on the workflow files without it.NOTICE: removed aws-lambda-go, pgx, pgxmock, golang-migrate and testcontainers. None of them is ingo.modorgo.sum. The remaining notices all match current dependencies.docs/cli/cloud-setup.mdanddocs/cli/README.md: the server, self-hosted, deploy-workflow,ci-cd-permissions/andterraform/environments/references now point at cloud-commitments-platform. This also removes the dead README anchor.CONTRIBUTING.md:./cudly --helpprints no version, so the bug-report guidance now asks for the commit SHA or release tag instead.These items were already fixed on main: item 2 (#2218), item 4 (no stale
.gitallowedcomments remain) and item 6 (the Makefile andgosec-hook.shboth usescripts/run-gosec.sh).Evidence
All runs are local, on macOS.
pre-commit run --all-filespasses, including markdownlint and check-yaml.golangci-lint config verifyis clean, and golangci-lint v2.10.1run ./...reports 0 issues.scripts/test-git-secrets-allowlist.shpasses 44/44.make buildpasses.git ls-files, every NOTICE removal againstgo.mod/go.sum, and the doc links and wording. They found two lows: a leftover exclude, and two more residue passages incloud-setup.md. Both are applied. The final confirmation found no actionable findings at ae20221.🤖 Generated with Claude Code